Fix: Skip non-vertex PLY elements instead of throwing#56
Merged
scier merged 1 commit intoscier:mainfrom Feb 17, 2026
Merged
Conversation
PLY files from tools like ml-sharp include extra metadata elements (extrinsic, intrinsic, image_size, frame, etc.) alongside vertex data. The reader was throwing unsupportedFileContents when encountering these non-vertex elements. Changed to skip them with `continue` instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thank you for the PR! Validated the regression and your fix. |
Author
|
No problem. Curious if you’ve tried to use Reality Composer Pro to record in 4K when a splat is up? Mine crashes instantly.
From: Sean Cier ***@***.***>
Date: Tuesday, February 17, 2026 at 5:45 PM
To: scier/MetalSplatter ***@***.***>
Cc: orbitalelliott ***@***.***>, Author ***@***.***>
Subject: Re: [scier/MetalSplatter] Fix: Skip non-vertex PLY elements instead of throwing (PR #56)
[https://avatars.githubusercontent.com/u/1134153?s=20&v=4]scier left a comment (scier/MetalSplatter#56)<#56 (comment)>
Thank you for the PR! Validated the regression and your fix.
—
Reply to this email directly, view it on GitHub<#56 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BXE2IGM7HQRNWMGDWZZ4JJD4MORZBAVCNFSM6AAAAACVHOOPWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJXGY3DEOJWGI>.
You are receiving this because you authored the thread.
|
Owner
|
I haven’t used RCP to record anything lately. RCP crashes or MetalSplatter? If it’s MetalSplatter crashing, then guessing it’s a side effect of the performance impact (or turning off foveated rendering, although I’ve run recently without foveation and it worked fine). And actually there’s a chance it’s related to a bug I’m in the middle of fixing that can cause problems around dropped frames. So once I fix that, might be worth trying again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PLY files from tools like ml-sharp include extra metadata elements alongside vertex data:
SplatPLYSceneReader.read()throwsunsupportedFileContents("Expected type index 0, found 1")when it encounters these non-vertex elements in the async stream, instead of skipping them.Fix
Changed the guard clause in
SplatPLYSceneReader.swift:51from throwing an error tocontinue, so non-vertex element types are silently skipped.Testing
Tested with ml-sharp PLY files containing 8 element types (vertex, extrinsic, intrinsic, image_size, frame, disparity, color_space, version). Vertex data loads correctly, metadata elements are skipped.